AngryPets Blog

Team Foundation Source Control Evil

VSTS is seriously cool. Period (more to come on that later).

Those of you that know me, know that I'm usually not one to criticize. However, I just found something that made my skin crawl. While poking around in the VSTEAMSCC database on a Team Foundation Server, I found tables prefixed with tbl_.

Egaaads. Let's hope that ALL gets cleaned up before the thing goes live. (Imagine calling all of your Classes, ClassPerson, or ClassAddress. It's just HORRID. (though Frans Bouma does *cough cough* bring up an interesting point about one thing we all do, and expect, that is effectively Hungarian in origin)). Anyhow... hungarian notation doesn't belong in the DB. Period.

Existing Comments:

# re: Team Foundation Source Control Evil - Posted: 7/6/2005 12:43 AM - By: Brian
   Hehe...and here I almost thought this was going to be something _major_ ... :)

I think the question in any naming convention is: does it help make the code more readable or understandable?

I do agree about the "I" in interfaces, and just as it's pointed out in Frans' entry, it avoids confusion in inheriting vs. implementing (an interesting debate: would VB.NET developers find this redundant, since classes and interfaces are specified explicitly?). I admit though (and last we discussed, you did this too!) I do the same for ASP.NET controls (I use txtFirstName, chkRememberMe, etc.) ... but whether that's more readable, more understandable, or just personal preference is moot, I suppose?

But I do agree with you about tbl_ prefix.

# re: Team Foundation Source Control Evil - Posted: 7/6/2005 10:32 AM - By: Michael K. Campbell
   Yeah, naming conventions are good, and requisite (sp_ etc for special procedure is valid for _MS_ suppplied procs, etc.)

Hungarian notation _is_ a naming convention -- only it's the type of naming convention that makes people carsick (Joel Spolsky's words, not mine). That's why I freaked out when I saw it in the this DB. (If you don't know that those are tables, you're in waaaay over your head.)

# re: Team Foundation Source Control Evil - Posted: 7/6/2005 5:45 PM - By: Brian
   Right on... you know I have a Wrox book somewhere that encourages "sp_" for sprocs? (Forget the seldom understood fact that it's for _special_) ...

Add your own comment: